Make the mbtiles and pmtiles deps optional. #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes the `mbtiles-cp` bin optional. The binary is modestly smaller (by about 6%), but the target directory contains a lot less build products (by about 40%).
|
I think this broke because sprites was indirectly depending on tokio having certain features enabled. |
|
I'll be happy to merge the moment it passes CI. Let me know if you need help |
The sqlx crate indirectly brought in tokio/full.
nyurik
added a commit
to nyurik/martin
that referenced
this pull request
Jan 17, 2024
This also makes the `mbtiles-cp` bin optional. The binary is modestly smaller (by about 6%), but the target directory contains a lot less build products (by about 40%). --------- Co-authored-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes the
mbtiles-cpbin optional.The binary is modestly smaller (by about 6%), but the target directory contains a lot less build products (by about 40%).